Division by zero with TBarSeries

Narcís · Post by **Narcís** » Thu Sep 04, 2008 12:10 pm

Hi Manfred,

Thanks for the example project. I could reproduce the issue here and added it (TV52013371) to the list to be fixed for next releases. However, I can not confirm a fix will be inlcuded in next version.

manfred.gahr · Post by **manfred.gahr** » Sat Sep 06, 2008 3:49 pm

narcis wrote:However, I can not confirm a fix will be inlcuded in next version.

Really such a pity

We have been waiting for this bugfix in TBarSeries for several months and now we can't install a correction because of another bug. Actually apart from TBarSeries bug we were quite satisfied with TeeChartPro 8.02. If you have a version control system (such as SVN or CVS), can't you just find a revision where it was fixed and apply a correction to old 8.02 code?

Regards,
Manfred

Narcís · Post by **Narcís** » Mon Sep 08, 2008 8:10 am

Hi Manfred,

I'm sorry to hear that. Yes, we have a version control system. If we know when a feature was brokend or a bug introduced exactly we try to rollback changes if they don't break anything else. Otherwise we try to find a more generic solution. In that particular case we will need to investigate the problem as it's not clear when it was introduced.

manfred.gahr · Post by **manfred.gahr** » Mon Sep 08, 2008 10:57 am

narcis wrote:In that particular case we will need to investigate the problem as it's not clear when it was introduced.

We probably misunderstood each other. I suggest to "add TBarSeries bugfix to 8.02" rather than "subtract CPU hang bug from 8.03". The first solution doesn't imply deep investion of the code but just a quick search in version control system log.

Regards,
Manfred

Narcís · Post by **Narcís** » Mon Sep 08, 2008 11:05 am

Hi Manfred,

Sorry for the misunderstanding. Ok, in that case, if you are a sourcecode customer you just need to make a little change in Series.pas at TCustomBarSeries.SetOtherBars method change this line:

Code: Select all

           Self.FMultiBar:=FMultiBar;

for this:

Code: Select all

           TCustomBarSeries(ParentChart.Series[t]).FMultiBar:=FMultiBar;

manfred.gahr · Post by **manfred.gahr** » Mon Sep 08, 2008 12:37 pm

Thanks Narcis,

Such a small change

Sorry but we don't have a sourcecode. Can't you rebuild ver 8.02 with this correction and give me a link?

Regards,
Manfred

Narcís · Post by **Narcís** » Mon Sep 08, 2008 12:46 pm

Hi Manfred,

I'll try to do so. Which IDE are you using?

Thanks in advance.

manfred.gahr · Post by **manfred.gahr** » Mon Sep 08, 2008 1:11 pm

CodeGear™ C++Builder® 2007 Version 11.0.2902.10471

Narcís · Post by **Narcís** » Mon Sep 08, 2008 1:28 pm

Hi Manfred,

Ok, I've compiled v8.02 sources with this change and included all compiled files in a zip package. I'm going to post it to our servers and send you the URL to download it.

Please let me know when you have downloaded the files as I'll remove them from the server.

Thanks in advance.

manfred.gahr · Post by **manfred.gahr** » Mon Sep 08, 2008 5:21 pm

Hi Narcis,

I downloaded an archive but "Division by zero" is still there. Are you sure you gave me the right link? Did you check it on your side?

Best Regards,
Manfred

Narcís · Post by **Narcís** » Tue Sep 09, 2008 8:33 am

Hi Manfred,

I'm not able to reproduce the problem here. Have you tried using the alternative I suggested on my first reply in the thread? If the problem persists please send us a simple example project we can run "as-is" to reproduce the problem here.

You can either post your files at news://www.steema.net/steema.public.attachments newsgroup or at our upload page.

Thanks in advance.

manfred.gahr · Post by **manfred.gahr** » Tue Sep 09, 2008 11:29 am

Hi Narcis,

I uploaded TeeTest802notfixed.zip. Push "Add Series" and "Convert to Bar". Division by zero occurs at next Paint. I included Tee811.bpl from your patched v8.02 into my archive to make sure it is really used during execution.

Regards,
Manfred

Narcís · Post by **Narcís** » Tue Sep 09, 2008 11:49 am

Hi Manfred,

Thanks for the example project. It works fine for me here. I installed same packages I sent to you using the TeeInstall.exe tool included in the zip package. First time you run it will uninstall existing packages and then will install new ones. Did you install the packages like that? Could you please check that your project is referencing new TeeChart packages?

Thanks in advance.

manfred.gahr · Post by **manfred.gahr** » Tue Sep 09, 2008 12:19 pm

Hi Narcis,

Do you want to say that you hit neither "Convert To Bar" problem nor "100% CPU hang on resize"? Did you recompile the project or just executed my EXE-file? Are you sure that file Tee811.bpl included into archive was used. Don't you have 8.03 libraries hanging around somewhere?

I did only a fully clean test, assuming that our customer is not going to run TeeInstall.exe. In fact he is even very restricted in accessing his hard disk, he used to run application from read-only network share. So I merely copied all necessary BPLs and DLLs to a virtual machine with newly installed Windows XP Pro SP3 and started my EXE. I uploaded a full test package TeeTest802notfixed_full.zip. Maybe I missed something, but this set of files was sufficient to start the application on a clean computer. Could you please unpack the entire content of the archive into a separate folder and try it once again?

Thanks,
Manfred

Narcís · Post by **Narcís** » Tue Sep 09, 2008 1:21 pm

Hi Manfred,

I checked my RAD Studio 2007 installation and checked that is referencing v8.02 packages with the modification I made. Then I uncompressed your packages again, ran the .exe on it and couldn't reproduce any of the issues. Same occured with the .exe I compiled myself.